Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a :gh: role to the documentation to link to GitHub issues #91888

Closed
ezio-melotti opened this issue Apr 24, 2022 · 4 comments
Closed

Add a :gh: role to the documentation to link to GitHub issues #91888

ezio-melotti opened this issue Apr 24, 2022 · 4 comments
Assignees
@ezio-melotti
Labels
docs type-feature

Comments

@ezio-melotti
Copy link
Member

@ezio-melotti ezio-melotti commented Apr 24, 2022

The :issue:`...` role has been updated in GH-32342 to redirect to GitHub issues, but it still expects bpo ids. A new :gh:`...` role is needed to link directly to new GitHub issues.
@ezio-melotti ezio-melotti added type-feature docs labels Apr 24, 2022
@ezio-melotti ezio-melotti self-assigned this Apr 24, 2022
@ezio-melotti ezio-melotti mentioned this issue Apr 24, 2022
Merged
@ezio-melotti ezio-melotti mentioned this issue Apr 24, 2022
Merged
ezio-melotti added a commit that referenced this issue Apr 25, 2022
@ezio-melotti @hugovk
gh-91888: add a :gh: role to the documentation (#91889)
f7641a2 
* Add a new :gh:`...` role for GitHub issues.

* Fix a GitHub id to use the :gh: role.

* Add Misc/NEWS entry.

* Refactoring and rephrasing.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
ezio-melotti added a commit to ezio-melotti/cpython that referenced this issue Apr 26, 2022
@ezio-melotti
pythongh-91888: Add a :gh: role to the documentation (pythonGH-91889).
cf4e09e
ezio-melotti added a commit to ezio-melotti/cpython that referenced this issue Apr 26, 2022
@ezio-melotti
[3.10] pythongh-91888: add a :gh: role to the documentation (python…
ed9b381 
…GH-91889)

* Add a new :gh:`...` role for GitHub issues.

* Fix a GitHub id to use the :gh: role.

* Add Misc/NEWS entry.

* Refactoring and rephrasing.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>.
(cherry picked from commit f7641a2)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
ezio-melotti added a commit to ezio-melotti/cpython that referenced this issue Apr 26, 2022
@ezio-melotti
pythongh-91888: Add a :gh: role to the documentation (pythonGH-91889).
1d2cc37
ezio-melotti added a commit to ezio-melotti/cpython that referenced this issue Apr 26, 2022
@ezio-melotti
[3.10] pythongh-91888: add a :gh: role to the documentation (python…
b7676fb 
…GH-91889)

* Add a new :gh:`...` role for GitHub issues.

* Fix a GitHub id to use the :gh: role.

* Add Misc/NEWS entry.

* Refactoring and rephrasing.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>.
(cherry picked from commit f7641a2)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
ezio-melotti added a commit to ezio-melotti/cpython that referenced this issue Apr 26, 2022
@ezio-melotti
pythongh-91888: Add a :gh: role to the documentation (pythonGH-91889).
ac050e9
ezio-melotti added a commit to ezio-melotti/cpython that referenced this issue Apr 26, 2022
@ezio-melotti
[3.8] pythongh-91888: add a :gh: role to the documentation (pythonG…
ef1ca7d 
…H-91889)

* Add a new :gh:`...` role for GitHub issues.

* Fix a GitHub id to use the :gh: role.

* Add Misc/NEWS entry.

* Refactoring and rephrasing.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>.
(cherry picked from commit f7641a2)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
ezio-melotti added a commit to ezio-melotti/cpython that referenced this issue Apr 26, 2022
@ezio-melotti
pythongh-91888: Add a :gh: role to the documentation (pythonGH-91889).
a72fe03
ezio-melotti added a commit to ezio-melotti/cpython that referenced this issue Apr 26, 2022
@ezio-melotti
[3.7] pythongh-91888: add a :gh: role to the documentation (pythonG…
66e1100 
…H-91889)

* Add a new :gh:`...` role for GitHub issues.

* Fix a GitHub id to use the :gh: role.

* Add Misc/NEWS entry.

* Refactoring and rephrasing.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>.
(cherry picked from commit f7641a2)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
ezio-melotti added a commit that referenced this issue Apr 26, 2022
@ezio-melotti
[3.10] gh-91888: add a :gh: role to the documentation (GH-91889) (#91934
4120bba 
)

* gh-91888: Add a :gh: role to the documentation (GH-91889).

* [3.10] gh-91888: add a `:gh:` role to the documentation (GH-91889)

* Add a new :gh:`...` role for GitHub issues.

* Fix a GitHub id to use the :gh: role.

* Add Misc/NEWS entry.

* Refactoring and rephrasing.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>.
(cherry picked from commit f7641a2)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
ezio-melotti added a commit that referenced this issue Apr 26, 2022
@ezio-melotti
[3.9] gh-91888: add a :gh: role to the documentation (GH-91889) (#9…
38be31e 
…1935)

* gh-91888: Add a :gh: role to the documentation (GH-91889).

* [3.9] gh-91888: add a `:gh:` role to the documentation (GH-91889)

* Add a new :gh:`...` role for GitHub issues.

* Fix a GitHub id to use the :gh: role.

* Add Misc/NEWS entry.

* Refactoring and rephrasing.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>.
(cherry picked from commit f7641a2)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented May 9, 2022

Fixed by #91889

@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented May 9, 2022

@kumaraditya303, I think there's still open backport PRs for this, for 3.8 and 3.7

@ezio-melotti
Copy link
Member Author

@ezio-melotti ezio-melotti commented May 9, 2022

I think there's still open backport PRs for this, for 3.8 and 3.7

Yes:

The others have been merged:

@ezio-melotti ezio-melotti reopened this May 9, 2022
ned-deily pushed a commit that referenced this issue May 10, 2022
@ezio-melotti
[3.7] gh-91888: add a :gh: role to the documentation (GH-91889) (GH…
73317e3 
…-91937)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>.
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
(cherry picked from commit f7641a2)
ezio-melotti added a commit that referenced this issue May 10, 2022
@ezio-melotti
[3.8] gh-91888: add a :gh: role to the documentation (GH-91889) (#9…
0638941 
…1936)

* gh-91888: Add a :gh: role to the documentation (GH-91889).

* [3.8] gh-91888: add a `:gh:` role to the documentation (GH-91889)

* Add a new :gh:`...` role for GitHub issues.

* Fix a GitHub id to use the :gh: role.

* Add Misc/NEWS entry.

* Refactoring and rephrasing.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>.
(cherry picked from commit f7641a2)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>

* Fix use of the default role in NEWS entry
@ezio-melotti
Copy link
Member Author

@ezio-melotti ezio-melotti commented May 10, 2022

All the backports have been merged, closing.

hello-adam pushed a commit to hello-adam/cpython that referenced this issue Jun 2, 2022
@ezio-melotti @hello-adam
[3.9] pythongh-91888: add a :gh: role to the documentation (pythonG…
fcbf82e 
…H-91889) (python#91935)

* pythongh-91888: Add a :gh: role to the documentation (pythonGH-91889).

* [3.9] pythongh-91888: add a `:gh:` role to the documentation (pythonGH-91889)

* Add a new :gh:`...` role for GitHub issues.

* Fix a GitHub id to use the :gh: role.

* Add Misc/NEWS entry.

* Refactoring and rephrasing.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>.
(cherry picked from commit f7641a2)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ezio-melotti ezio-melotti

Labels
docs type-feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ezio-melotti @kumaraditya303 @AlexWaygood