Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SpatialBundle/TransformBundle in examples #6002

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

devil-ira
Copy link
Contributor

@devil-ira devil-ira commented Sep 17, 2022

Does what it do

@mockersf
Copy link
Member

mockersf commented Sep 19, 2022

I think I would prefer examples to avoid chaining insert commands on the same entity, as that's currently not a great pattern in Bevy

@devil-ira
Copy link
Contributor Author

devil-ira commented Sep 20, 2022

#2975 just got merged :)
Am I correct in thinking that will solve your issue with this @mockersf?

@mockersf
Copy link
Member

mockersf commented Sep 20, 2022

yup, once this PR is update to only issue one command each time 👍

@alice-i-cecile alice-i-cecile added C-Examples An addition or correction to our examples C-Code-Quality A section of code that is hard to understand or change labels Sep 24, 2022
@devil-ira
Copy link
Contributor Author

devil-ira commented Sep 26, 2022

This has been rebased on top of the recent changes to spawning/inserting

@rparrett rparrett added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 6, 2022
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 10, 2022

Merge conflict.

@alice-i-cecile
Copy link
Member

alice-i-cecile commented Oct 10, 2022

@devil-ira can you fix up these merge conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants