bpo-38360: macOS: support alternate form of -isysroot flag #16480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
jmroot
changed the title
…16480) It is possible to use either '-isysroot /some/path' (with a space) or '-isysroot/some/path' (no space in between). Support both forms in places where special handling of -isysroot is done, rather than just the first form.
|
(Ack) |
|
@ned-deily Ping. It would be nice to get this in to the 3.9.0 alphas. |
ned-deily
pushed a commit
to ned-deily/cpython
that referenced
this issue
Apr 22, 2020
…16480) It is possible to use either '-isysroot /some/path' (with a space) or '-isysroot/some/path' (no space in between). Support both forms in places where special handling of -isysroot is done, rather than just the first form.
|
Thanks @jmroot for the PR, and @ned-deily for merging it |
|
Thanks @jmroot for the PR, and @ned-deily for merging it |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Apr 22, 2020
…16480) It is possible to use either '-isysroot /some/path' (with a space) or '-isysroot/some/path' (no space in between). Support both forms in places where special handling of -isysroot is done, rather than just the first form. Co-authored-by: Ned Deily <nad@python.org> (cherry picked from commit b310700) Co-authored-by: Joshua Root <jmr@macports.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Apr 22, 2020
…16480) It is possible to use either '-isysroot /some/path' (with a space) or '-isysroot/some/path' (no space in between). Support both forms in places where special handling of -isysroot is done, rather than just the first form. Co-authored-by: Ned Deily <nad@python.org> (cherry picked from commit b310700) Co-authored-by: Joshua Root <jmr@macports.org>
|
GH-19658 is a backport of this pull request to the 3.8 branch. |
|
GH-19657 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this issue
Apr 22, 2020
It is possible to use either '-isysroot /some/path' (with a space) or '-isysroot/some/path' (no space in between). Support both forms in places where special handling of -isysroot is done, rather than just the first form. Co-authored-by: Ned Deily <nad@python.org> (cherry picked from commit b310700) Co-authored-by: Joshua Root <jmr@macports.org>
miss-islington
added a commit
that referenced
this issue
Apr 22, 2020
It is possible to use either '-isysroot /some/path' (with a space) or '-isysroot/some/path' (no space in between). Support both forms in places where special handling of -isysroot is done, rather than just the first form. Co-authored-by: Ned Deily <nad@python.org> (cherry picked from commit b310700) Co-authored-by: Joshua Root <jmr@macports.org>
vegerot
pushed a commit
to vegerot/cpython
that referenced
this issue
Jun 10, 2020
…16480) It is possible to use either '-isysroot /some/path' (with a space) or '-isysroot/some/path' (no space in between). Support both forms in places where special handling of -isysroot is done, rather than just the first form. Co-authored-by: Ned Deily <nad@python.org>
vegerot
pushed a commit
to vegerot/cpython
that referenced
this issue
Jun 10, 2020
…16480) It is possible to use either '-isysroot /some/path' (with a space) or '-isysroot/some/path' (no space in between). Support both forms in places where special handling of -isysroot is done, rather than just the first form. Co-authored-by: Ned Deily <nad@python.org>
gmelikov
pushed a commit
to gmelikov/cpython
that referenced
this issue
Aug 22, 2020
…16480) It is possible to use either '-isysroot /some/path' (with a space) or '-isysroot/some/path' (no space in between). Support both forms in places where special handling of -isysroot is done, rather than just the first form. Co-authored-by: Ned Deily <nad@python.org>
chrisburr
pushed a commit
to chrisburr/cpython
that referenced
this issue
Dec 9, 2020
…16480) It is possible to use either '-isysroot /some/path' (with a space) or '-isysroot/some/path' (no space in between). Support both forms in places where special handling of -isysroot is done, rather than just the first form. Co-authored-by: Ned Deily <nad@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
It is possible to use either '-isysroot /some/path' or
'-isysroot/some/path' (no space in between). Support both forms in
places where special handling of -isysroot is done, rather than just
the first form.
https://bugs.python.org/issue38360