Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39794: Add --without-decimal-contextvar #18702

Merged
merged 2 commits into from Feb 29, 2020
Merged

bpo-39794: Add --without-decimal-contextvar #18702

merged 2 commits into from Feb 29, 2020

Conversation

skrah
Copy link
Contributor

@skrah skrah commented Feb 29, 2020

  This optionally builds _decimal with just a thread local context.
@python python deleted a comment from codecov bot Feb 29, 2020
@skrah skrah merged commit 815280e into python:master Feb 29, 2020
@bedevere-bot
Copy link

bedevere-bot commented Feb 29, 2020

@skrah: Please replace # with GH- in the commit message next time. Thanks!

@skrah skrah deleted the with_decimal_context_var branch Feb 29, 2020
sthagen added a commit to sthagen/python-cpython that referenced this pull request Feb 29, 2020
bpo-39794: Add --without-decimal-contextvar (python#18702)
@miss-islington
Copy link
Contributor

miss-islington commented Feb 29, 2020

Thanks @skrah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Feb 29, 2020

Thanks @skrah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Feb 29, 2020

Sorry, @skrah, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 815280eb160af637e1347213659f9236adf78f80 3.8

@miss-islington
Copy link
Contributor

miss-islington commented Feb 29, 2020

Sorry @skrah, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 815280eb160af637e1347213659f9236adf78f80 3.7

@bedevere-bot
Copy link

bedevere-bot commented Feb 29, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Shared 3.x has failed when building commit 815280e.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/152/builds/345) and take a look at the build logs.
  4. Check if the failure is related to this commit (815280e) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/152/builds/345

Failed tests:

  • test_concurrent_futures

Failed subtests:

  • test_killed_child - test.test_concurrent_futures.ProcessPoolForkProcessPoolExecutorTest

Summary of the results of the build (if available):

== Tests result: FAILURE then ENV CHANGED ==

399 tests OK.

10 slowest tests:

  • test_multiprocessing_spawn: 8 min 22 sec
  • test_tokenize: 8 min 17 sec
  • test_unparse: 7 min 43 sec
  • test_lib2to3: 5 min 37 sec
  • test_concurrent_futures: 5 min 6 sec
  • test_unicodedata: 5 min 2 sec
  • test_multiprocessing_forkserver: 3 min 56 sec
  • test_pickle: 3 min 48 sec
  • test_subprocess: 3 min 34 sec
  • test_asyncio: 3 min 17 sec

1 test altered the execution environment:
test_multiprocessing_spawn

20 tests skipped:
test_dbm_gnu test_devpoll test_epoll test_gdb test_idle test_ioctl
test_msilib test_ossaudiodev test_spwd test_startfile test_tcl
test_tix test_tk test_ttk_guionly test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_concurrent_futures

Total duration: 32 min 35 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/test/test_concurrent_futures.py", line 130, in tearDown
    self.executor.shutdown(wait=True)
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/concurrent/futures/process.py", line 699, in shutdown
    self._queue_management_thread_wakeup.wakeup()
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/concurrent/futures/process.py", line 94, in wakeup
    self._writer.send_bytes(b"")
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/connection.py", line 200, in send_bytes
    self._send_bytes(m[offset:offset + size])
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/connection.py", line 411, in _send_bytes
    self._send(header + buf)
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/connection.py", line 368, in _send
    n = write(self._handle, buf)
OSError: [Errno 9] Bad file descriptor

@bedevere-bot
Copy link

bedevere-bot commented Feb 29, 2020

GH-18713 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

bedevere-bot commented Feb 29, 2020

GH-18714 is a backport of this pull request to the 3.7 branch.

skrah added a commit that referenced this pull request Feb 29, 2020
skrah added a commit that referenced this pull request Feb 29, 2020
* bpo-39794: Add --without-decimal-contextvar (#18702)

(cherry picked from commit 815280e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants