New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST, BLD: Fix failing aarch64 wheel builds. #22418
Conversation
Hmm, the aarch64 wheel builds are reported as passing, but they are actually failing. |
Which test? Does it specify a |
Trying to figure that out. The one I currently suspect does use |
Looks like
May be a problem with memory detection on aarch64. |
Hmmm, agree that it looks like I estimated it for 32bit floats and then also added 64bit or so. But strange that it requires the unconditional skip. OTOH not sure it is worth to dig deep, it seems also likely to me that the available memory detection is simply not be reliable on aarch. |
@seberg Your estimate was low, but even with that fixed it still goes OOM. For the 1.23.4 release I will probably skip it unconditionally, but I want to fool with it a bit on main to see what is going wrong. |
OK, here is the problem:
That's 120 GB. I wonder if we should try getting the allowed memory |
I could not find the machine information in the travis documentation in the ten minutes I tried. Would it be easy to add |
@mattip I think the machine the test is running on does have 120 GB of memory, but the memory allowed to the process is much less. I also wonder why we don't get memory_error instead of OOM. There is a |
Trying the environment variable approach. |
The aarch64 wheel build tests are failing with OOM. The new test for complex128 dot for huge vectors is responsible as the useable memory is incorrectly determined and the check for sufficient memory fails. The fix here is to define the `NPY_AVAILABLE_MEM="4 GB"` environment variable before the test call in `cibw_test_command.sh`.
Self merging so I can backport and do the 1.23.4 release. |
The aarch64 wheel build tests are failing with OOM. The new test for complex128 dot for huge vectors is responsible as the usable memory is incorrectly determined and the check for sufficient memory fails. The fix here is to set
NPY_AVAILABLE_MEM="4 GB"
in the environment before calling the test incibw_test_command.sh
.