Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC only use chi2 on binary and counts features #24684

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

glemaitre
Copy link
Contributor

@glemaitre glemaitre commented Oct 17, 2022

closes #24593
closes #21455

Improve the documentation linked to chi2. From the following issue #21455 (comment), we should:

TODO:

  • (Already in main) Improve the documentation in the meanwhile to mention that it is only for the above use case.
  • Improve the examples by using chi2 only on the expected features type.
  • Improve the user guide where we should explicitly show when to use this statistic.

@glemaitre glemaitre marked this pull request as draft Oct 17, 2022
@glemaitre glemaitre marked this pull request as ready for review Oct 18, 2022
doc/modules/feature_selection.rst Outdated Show resolved Hide resolved
Co-authored-by: Tim Head <betatim@gmail.com>
doc/modules/feature_selection.rst Outdated Show resolved Hide resolved
glemaitre and others added 2 commits Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants