Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.9 upgrade #1827

Merged
merged 5 commits into from Jul 28, 2021
Merged

Python 3.9 upgrade #1827

merged 5 commits into from Jul 28, 2021

Conversation

ewdurbin
Copy link
Member

@ewdurbin ewdurbin commented Jul 27, 2021

Minimal work to reach passing tests on Python 3.9.

Removes unmaintained Vagrant environment.

@ewdurbin ewdurbin mentioned this pull request Jul 27, 2021
Closed
@ewdurbin ewdurbin temporarily deployed to pythondotorg-staging Jul 27, 2021 Inactive
@luzfcb
Copy link
Contributor

@luzfcb luzfcb commented Jul 27, 2021

@ewdurbin

I have this setting in my .pre-commit-config.yaml and it has worked fine to keep things up to date and avoid old code.

repos:
  - repo: https://github.com/asottile/pyupgrade
    rev: v2.23.0
    hooks:
      - id: pyupgrade
        args: ['--py3-plus', '--py39-plus']
pip install pre-commit
pre-commit install
pre-commit run --all-files

@ewdurbin
Copy link
Member Author

@ewdurbin ewdurbin commented Jul 27, 2021 •
edited

worth it just for this 😳

Screen Shot 2021-07-27 at 12 22 32 PM

@ewdurbin ewdurbin temporarily deployed to pythondotorg-staging Jul 27, 2021 Inactive
berinhard
berinhard approved these changes Jul 27, 2021
View changes
Copy link
Collaborator

@berinhard berinhard left a comment

I <3 f-strings and not needing to live in the __future__ anymore

@ewdurbin ewdurbin merged commit 3343536 into main Jul 28, 2021
2 checks passed
@ewdurbin ewdurbin deleted the python39_upgrade branch Jul 28, 2021
@coderanger coderanger mentioned this pull request Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berinhard berinhard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ewdurbin @luzfcb @berinhard