Incompatible event modifiers on keypress between 2.2.2 and 2.2.1 #5146

m-schier · 2017-03-09T10:11:43Z

From version 2.2.2 to 2.2.1 it appears the logic for handling keypress events with a key-modifier and the prevent-modifier has changed.

In 2.2.1 an 'keypress.enter.prevent' would only prevent default action for the enter key, but in 2.2.2 it prevents every key.

I expected the behaviour to stay consistent with both releases, unless this change is intended.

Compare
2.2.1: https://jsfiddle.net/p4ay5v9c/2/
2.2.2: https://jsfiddle.net/z17jjxh6/1/

From my understanding the changelog for 2.2.2 does not list this change, so I reckon it is not intentional.

posva · 2017-03-09T10:25:35Z

The change is not intentional, thanks for pointing it out. I'll take a look

* fix wrong order of generate modifier code * add unit test of #5146 * Update events.js

yyx990803 · 2017-03-10T01:54:41Z

Fixed via #5147

posva added 2.2 regression labels Mar 9, 2017

Kingwl mentioned this issue Mar 9, 2017

fix wrong order of generate modifier code #5147

Merged

Kingwl pushed a commit to Kingwl/vue that referenced this issue Mar 9, 2017

add unit test of vuejs#5146

5209064

yyx990803 pushed a commit that referenced this issue Mar 10, 2017

fix wrong order of generate modifier code (#5147)

4964b25

* fix wrong order of generate modifier code * add unit test of #5146 * Update events.js

yyx990803 closed this as completed Mar 10, 2017

Incompatible event modifiers on keypress between 2.2.2 and 2.2.1 #5146

Incompatible event modifiers on keypress between 2.2.2 and 2.2.1 #5146

m-schier commented Mar 9, 2017 •

edited

posva commented Mar 9, 2017

yyx990803 commented Mar 10, 2017

Incompatible event modifiers on keypress between 2.2.2 and 2.2.1 #5146

Incompatible event modifiers on keypress between 2.2.2 and 2.2.1 #5146

Comments

m-schier commented Mar 9, 2017 • edited

posva commented Mar 9, 2017

yyx990803 commented Mar 10, 2017

m-schier commented Mar 9, 2017 •

edited