gh-94808: Add test coverage for PyObject_HasAttrString #96627
+40
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonadChains
changed the title
222 tasks
mdboom
suggested changes
Sep 7, 2022
Thanks so much for the contribution. It looks great other than a few minor comments.
| Py_RETURN_TRUE; | ||
| else | ||
| Py_RETURN_FALSE; | ||
| } |
There was a problem hiding this comment.
Sorry for the nit, but I don't think there's automatic tooling to check this. Can you reformat this to comply with PEP7.
|
|
||
| a = A() | ||
| self.assertEqual(_testcapi.hasattr_string(a, "attr"), True) | ||
| self.assertEqual(_testcapi.hasattr_string(a, "noattr"), False) |
There was a problem hiding this comment.
It might also be worth asserting that there's no exception set in this case:
self.assertEqual(sys.exc_info(), (None, None, None))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Add test to cover the function
HasAttrStringof the C API.