Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collections.abc.ValuesView is not sufficently tested #98512

Closed
sobolevn opened this issue Oct 21, 2022 · 1 comment
Closed

collections.abc.ValuesView is not sufficently tested #98512

sobolevn opened this issue Oct 21, 2022 · 1 comment
Assignees
@sobolevn
Labels
stdlib Python modules in the Lib dir tests Tests in the Lib/test dir

Comments

@sobolevn
Copy link
Member

sobolevn commented Oct 21, 2022 •
edited by bedevere-bot

There are places where it is either not complete:

cpython/Lib/test/test_dictviews.py

Lines 338 to 340 in 49f6106

self.assertIsInstance(d.values(), collections.abc.ValuesView)
self.assertIsInstance(d.values(), collections.abc.MappingView)
self.assertIsInstance(d.values(), collections.abc.Sized)

Not base classes are covered here. But, I guess it should be.

Or there are places where it is not tested at all:

cpython/Lib/test/test_collections.py

Lines 1866 to 1869 in 49f6106

self.assertIsInstance(mymap.keys(), Set)
self.assertIsInstance(mymap.keys(), KeysView)
self.assertIsInstance(mymap.items(), Set)
self.assertIsInstance(mymap.items(), ItemsView)

I will go through places like this and cover ValuesView.
Noticed while working on #98511
@sobolevn sobolevn added tests Tests in the Lib/test dir stdlib Python modules in the Lib dir labels Oct 21, 2022
@sobolevn sobolevn self-assigned this Oct 21, 2022
@sobolevn sobolevn mentioned this issue Oct 21, 2022
Open
sobolevn added a commit to sobolevn/cpython that referenced this issue Oct 21, 2022
@sobolevn
pythongh-98512: Add more tests for ValuesView and KeysView
0c579a4
@bedevere-bot bedevere-bot mentioned this issue Oct 21, 2022
Merged
JelleZijlstra pushed a commit that referenced this issue Nov 3, 2022
@sobolevn
gh-98512: Add more tests for ValuesView (#98515)
29e027c
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 3, 2022
@sobolevn @miss-islington
pythongh-98512: Add more tests for ValuesView (pythonGH-98515)
4cab3fc 
(cherry picked from commit 29e027c)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot mentioned this issue Nov 3, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 3, 2022
@sobolevn @miss-islington
pythongh-98512: Add more tests for ValuesView (pythonGH-98515)
7a11786 
(cherry picked from commit 29e027c)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot mentioned this issue Nov 3, 2022
Merged
miss-islington added a commit that referenced this issue Nov 3, 2022
@miss-islington @sobolevn
gh-98512: Add more tests for ValuesView (GH-98515)
27dc6db 
(cherry picked from commit 29e027c)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this issue Nov 3, 2022
@miss-islington @sobolevn
gh-98512: Add more tests for ValuesView (GH-98515)
a02979f 
(cherry picked from commit 29e027c)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@hauntsaninja
Copy link
Contributor

hauntsaninja commented Nov 6, 2022

Thanks, looks like this is completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
stdlib Python modules in the Lib dir tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sobolevn @hauntsaninja