Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfiler] Fix overflow issue in Forms panel #47731

Merged
merged 1 commit into from Oct 1, 2022
Merged

Conversation

zolikonta
Copy link
Contributor

@zolikonta zolikonta commented Sep 29, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets no
License MIT
Doc PR no

Fix overflow issue in WebProfiler Forms panel

Hides overflowing content in the tree view and adds ellipsis to the end.
Also adds title attribute with the field names so they get shown fully on hover.

Before:
Screenshot 2022-09-29 at 15-49-43 Symfony Profiler
After:
Screenshot 2022-09-29 at 15-49-44 Symfony Profiler

You might want to consider widening #tree-menu especially in width-full.

This PR applies to 4.4 and 5.4 branch as well not sure about 6.2 though I noticed a redesign but haven't got the chance to check it out.

Thank you

@carsonbot
Copy link

carsonbot commented Sep 29, 2022

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@zolikonta zolikonta marked this pull request as ready for review Sep 29, 2022
@carsonbot carsonbot added this to the 4.4 milestone Sep 29, 2022
@zolikonta zolikonta changed the title Fix overflow issue in WebProfiler Forms panel [WebProfiler] Fix overflow issue in Forms panel Sep 30, 2022
@OskarStark OskarStark requested a review from javiereguiluz Sep 30, 2022
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Thanks @zolikonta!

About the 6.2 redesign: yes, let's merge this up to that branch and later we can tweak/fix things as needed.

@fabpot
Copy link
Member

fabpot commented Oct 1, 2022

Thank you @zolikonta.

@fabpot fabpot merged commit 289d6b4 into symfony:4.4 Oct 1, 2022
10 checks passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants