Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DependencyInjection] Don't reset env placeholders during compilation #45529

Merged
merged 1 commit into from Feb 24, 2022
Merged

[DependencyInjection] Don't reset env placeholders during compilation #45529

merged 1 commit into from Feb 24, 2022

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Feb 23, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #36466
License MIT
Doc PR -

Resetting causes placeholders to be lost when the env-var-in-config is used by several bundles (from linked issue.)

@carsonbot carsonbot added this to the 4.4 milestone Feb 23, 2022
@nicolas-grekas nicolas-grekas mentioned this pull request Feb 23, 2022
Closed
@nicolas-grekas nicolas-grekas merged commit 7ce0ebe into symfony:4.4 Feb 24, 2022
10 checks passed
This was referenced Feb 28, 2022
Merged
Merged
Merged
@nicolas-grekas nicolas-grekas deleted the di-no-reset branch Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug DependencyInjection Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicolas-grekas @carsonbot