Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create combination_sum.py #7403

Merged
merged 5 commits into from Oct 18, 2022
Merged

Create combination_sum.py #7403

merged 5 commits into from Oct 18, 2022

Conversation

creatornadiran
Copy link
Contributor

@creatornadiran creatornadiran commented Oct 18, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@creatornadiran
Copy link
Contributor Author

creatornadiran commented Oct 18, 2022

@cclauss @CaedenPH I have reopened pull request for combination_sum.py could you review my commit again?

@creatornadiran @cclauss
Adds doctests
084dcba 
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss reviewed Oct 18, 2022
View changes
backtracking/combination_sum.py Outdated
>>> combination_sum([2, 3, 6, 7], 7)
[[2, 2, 3], [7]]
>>> combination_sum([-8, 2.3, 0], 1)
Put the right answer here
Copy link
Member

@cclauss cclauss Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this line so that the tests are green ✅

Copy link
Contributor Author

@creatornadiran creatornadiran Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I didn't notice. I have added constraints instead.

cclauss
cclauss reviewed Oct 18, 2022
View changes
backtracking/combination_sum.py Outdated
@@ -37,8 +44,6 @@ def combination_sum(candidates: list, target: int) -> list:
[[2, 2, 2, 2], [2, 3, 3], [3, 5]]
>>> combination_sum([2, 3, 6, 7], 7)
[[2, 2, 3], [7]]
>>> combination_sum([-8, 2.3, 0], 1)
Copy link
Member

@cclauss cclauss Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this test?

Copy link
Contributor Author

@creatornadiran creatornadiran Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was breaking the constraints. I have added again.

@cclauss cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 18, 2022
cclauss
cclauss approved these changes Oct 18, 2022
View changes
Copy link
Member

@cclauss cclauss left a comment

Rock and roll!

@cclauss cclauss merged commit b90ec30 into TheAlgorithms:master Oct 18, 2022
2 checks passed
creatornadiran added a commit to creatornadiran/Python that referenced this pull request Oct 18, 2022
@creatornadiran
Revert "Create combination_sum.py (TheAlgorithms#7403)"
9e9bf61 
This reverts commit b90ec30.
@TheAlgorithms TheAlgorithms deleted a comment from creatornadiran Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@creatornadiran @cclauss