[DependencyInjection] Cast tag attribute value to string #44639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
ruudk
force-pushed
the
set-attribute-nullable-php-81
branch
from
59c0a3d
to
26e56fb
Compare
derrabus
reviewed
Dec 15, 2021
DOMElement::setAttribute(): Passing null to parameter symfony#2 ($value) of type string is deprecated This happens when a tag value is `null` on PHP 8.1.
ruudk
force-pushed
the
set-attribute-nullable-php-81
branch
from
26e56fb
to
8fe5fce
Compare
derrabus
approved these changes
Dec 15, 2021
derrabus
changed the title
fabpot
approved these changes
Dec 17, 2021
|
Thank you @ruudk. |
This was referenced Dec 29, 2021
Merged
Merged
Merged
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This happens when a tag value is
nullon PHP 8.1.