[Cache] disable lock on CLI #44669
Merged
[Cache] disable lock on CLI #44669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
cache-no-lock-on-cli
branch
from
15f5e09
to
b968514
Compare
|
The issue was talking about problems happening in Apache, so I doubt that disabling it only on CLI will fix it. |
|
It was about apache calling commands in a subprocess, isn't it? |
|
#41130 (comment) should be checked, as it talks about nested caching in parallell requests |
|
Calling |
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I thought using semaphores would fix the linked issue but I'm proposing to revert them in #44667
Instead, I think we should disable the lock on CLI processes.
The purpose of having locks enabled by default is to prevent cache stamped at deploy time. Disabling the lock on CLI still provides this protection on eg FPM.
For ppl that really want a lock between eg crons and FPM, the lock component should be used instead.