New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to depreciated QasmSimulator #7417
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
cclauss
reviewed
Oct 19, 2022
quantum/q_full_adder.py
Outdated
@@ -10,13 +10,12 @@ | |||
|
|||
import math | |||
|
|||
import qiskit | |||
from qiskit import Aer, ClassicalRegister, QuantumCircuit, QuantumRegister, execute | |||
import qiskit as q |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using just q
reduces readability for new users of qiskit and does not really save much space.
Suggested change
import qiskit as q | |
import qiskit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes made
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
This PR modified some existing files.
hacktoberfest
hacktoberfest-accepted
Accepted to be counted towards Hacktoberfest
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Describe your change:
Replaced instances of
qiskit.Aer.get_backend("qasm_simulator")
inquantum/
withq.Aer.get_backend("aer_simulator")
, as the former is depreciated and raises warnings (Qiskit's documentation says thatQasmSimulator
is legacy).This PR edits multiple code files because they all raise the same warning and are mentioned in the same GitHub issue.
Fixes #7308
Checklist:
Fixes: #{$ISSUE_NO}
.