Added new scripts to Python>ciphers #7506
Conversation
Created a rsa_encryption python script
created rsa_decrytion.py script (continuation of rsa_encryption.py file)
created rsa_decryption.py file (continuation of rsa_encryption.py file)
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://web.archive.org/web/20250523010038im_/https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| from base64 import b64encode, b64decode | ||
| hash = "SHA-256" | ||
|
|
||
| def newkeys(keysize): |
There was a problem hiding this comment.
Please provide return type hint for the function: newkeys. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file ciphers/rsa_decryption.py, please provide doctest for the function newkeys
Please provide type hint for the parameter: keysize
| private, public = key, key.publickey() | ||
| return public, private | ||
|
|
||
| def importKey(externKey): |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: importKey
Please provide return type hint for the function: importKey. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file ciphers/rsa_decryption.py, please provide doctest for the function importKey
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: externKey
Please provide type hint for the parameter: externKey
| def importKey(externKey): | ||
| return RSA.importKey(externKey) | ||
|
|
||
| def getpublickey(priv_key): |
There was a problem hiding this comment.
Please provide return type hint for the function: getpublickey. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file ciphers/rsa_decryption.py, please provide doctest for the function getpublickey
Please provide type hint for the parameter: priv_key
| def getpublickey(priv_key): | ||
| return priv_key.publickey() | ||
|
|
||
| def encrypt(message, pub_key): |
There was a problem hiding this comment.
Please provide return type hint for the function: encrypt. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file ciphers/rsa_decryption.py, please provide doctest for the function encrypt
Please provide type hint for the parameter: message
Please provide type hint for the parameter: pub_key
| return signer.sign(digest) | ||
|
|
||
| # Authentication | ||
| def verify(message, signature, pub_key): |
There was a problem hiding this comment.
Please provide return type hint for the function: verify. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file ciphers/rsa_decryption.py, please provide doctest for the function verify
Please provide type hint for the parameter: message
Please provide type hint for the parameter: signature
Please provide type hint for the parameter: pub_key
| We will use a function to generate new keys | ||
| or a pair of public and private key using the following code | ||
| """ | ||
| def newkeys(keysize): |
There was a problem hiding this comment.
Please provide return type hint for the function: newkeys. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file ciphers/rsa_encryption.py, please provide doctest for the function newkeys
Please provide type hint for the parameter: keysize
| private, public = key, key.publickey() | ||
| return public, private | ||
|
|
||
| def importKey(externKey): |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: importKey
Please provide return type hint for the function: importKey. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file ciphers/rsa_encryption.py, please provide doctest for the function importKey
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: externKey
Please provide type hint for the parameter: externKey
| def importKey(externKey): | ||
| return RSA.importKey(externKey) | ||
|
|
||
| def getpublickey(priv_key): |
There was a problem hiding this comment.
Please provide return type hint for the function: getpublickey. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file ciphers/rsa_encryption.py, please provide doctest for the function getpublickey
Please provide type hint for the parameter: priv_key
| `message` and `pub_key` which refers to Public key. | ||
| A public key is used for encryption and private key is used for decryption. | ||
| """ | ||
| def encrypt(message, pub_key): |
There was a problem hiding this comment.
Please provide return type hint for the function: encrypt. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file ciphers/rsa_encryption.py, please provide doctest for the function encrypt
Please provide type hint for the parameter: message
Please provide type hint for the parameter: pub_key
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| while i >= 0: | ||
| translated = translated + message[i] | ||
| i = i - 1 | ||
| print(“The cipher text is : “, translated) |
There was a problem hiding this comment.
An error occured while parsing the file: ciphers/reverse_cipher.py
Traceback (most recent call last):
File "/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line 145, in parse
reports = lint_file(
libcst._exceptions.ParserSyntaxError: Syntax Error @ 8:7.
'“' is not a valid token.
print(“The cipher text is : “, translated)
^| hash = "SHA-256" | ||
|
|
||
|
|
||
| def newkeys(keysize): |
There was a problem hiding this comment.
Please provide return type hint for the function: newkeys. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file ciphers/rsa_decryption.py, please provide doctest for the function newkeys
Please provide type hint for the parameter: keysize
| return public, private | ||
|
|
||
|
|
||
| def importKey(externKey): |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: importKey
Please provide return type hint for the function: importKey. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file ciphers/rsa_decryption.py, please provide doctest for the function importKey
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: externKey
Please provide type hint for the parameter: externKey
| return RSA.importKey(externKey) | ||
|
|
||
|
|
||
| def getpublickey(priv_key): |
There was a problem hiding this comment.
Please provide return type hint for the function: getpublickey. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file ciphers/rsa_decryption.py, please provide doctest for the function getpublickey
Please provide type hint for the parameter: priv_key
| return priv_key.publickey() | ||
|
|
||
|
|
||
| def encrypt(message, pub_key): |
There was a problem hiding this comment.
Please provide return type hint for the function: encrypt. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file ciphers/rsa_decryption.py, please provide doctest for the function encrypt
Please provide type hint for the parameter: message
Please provide type hint for the parameter: pub_key
|
|
||
|
|
||
| # Authentication | ||
| def verify(message, signature, pub_key): |
There was a problem hiding this comment.
Please provide return type hint for the function: verify. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file ciphers/rsa_decryption.py, please provide doctest for the function verify
Please provide type hint for the parameter: message
Please provide type hint for the parameter: signature
Please provide type hint for the parameter: pub_key
| """ | ||
|
|
||
|
|
||
| def newkeys(keysize): |
There was a problem hiding this comment.
Please provide return type hint for the function: newkeys. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file ciphers/rsa_encryption.py, please provide doctest for the function newkeys
Please provide type hint for the parameter: keysize
| return public, private | ||
|
|
||
|
|
||
| def importKey(externKey): |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: importKey
Please provide return type hint for the function: importKey. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file ciphers/rsa_encryption.py, please provide doctest for the function importKey
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: externKey
Please provide type hint for the parameter: externKey
| return RSA.importKey(externKey) | ||
|
|
||
|
|
||
| def getpublickey(priv_key): |
There was a problem hiding this comment.
Please provide return type hint for the function: getpublickey. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file ciphers/rsa_encryption.py, please provide doctest for the function getpublickey
Please provide type hint for the parameter: priv_key
| """ | ||
|
|
||
|
|
||
| def encrypt(message, pub_key): |
There was a problem hiding this comment.
Please provide return type hint for the function: encrypt. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file ciphers/rsa_encryption.py, please provide doctest for the function encrypt
Please provide type hint for the parameter: message
Please provide type hint for the parameter: pub_key
|
Please read CONTRIBUTING.md |
Describe your change:
Added new cipher scripts to Python>ciphers
Checklist:
Fixes: #{$ISSUE_NO}.