Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-97937: dis docs: add adaptive=False #97939

Merged
merged 5 commits into from Oct 25, 2022
Merged

gh-97937: dis docs: add adaptive=False #97939

merged 5 commits into from Oct 25, 2022
+29 −13

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Oct 5, 2022 •
edited by bedevere-bot

@JelleZijlstra JelleZijlstra requested a review from brandtbucher Oct 5, 2022
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Oct 5, 2022
hauntsaninja
hauntsaninja reviewed Oct 6, 2022
View changes
Doc/library/dis.rst Outdated Show resolved Hide resolved
@JelleZijlstra @hauntsaninja
Update Doc/library/dis.rst
57697f1 
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
brandtbucher
brandtbucher approved these changes Oct 25, 2022
View changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Looks good, thanks!

Doc/library/dis.rst Outdated Show resolved Hide resolved
@JelleZijlstra @brandtbucher
Update Doc/library/dis.rst
b9eb5f6 
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@JelleZijlstra JelleZijlstra self-assigned this Oct 25, 2022
@JelleZijlstra JelleZijlstra merged commit 5d8bf2b into python:main Oct 25, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 25, 2022

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 25, 2022

Sorry @JelleZijlstra, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 5d8bf2b106e694423bafaa3e1ea1edf20037573c 3.11

@JelleZijlstra JelleZijlstra deleted the adaptive branch Oct 25, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Oct 25, 2022

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 25, 2022

GH-98679 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 25, 2022
@JelleZijlstra @miss-islington
pythongh-97937: dis docs: add adaptive=False (pythonGH-97939)
9166fbe 
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
(cherry picked from commit 5d8bf2b)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
miss-islington added a commit that referenced this pull request Oct 25, 2022
@miss-islington @JelleZijlstra
gh-97937: dis docs: add adaptive=False (GH-97939)
4fc042f 
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
(cherry picked from commit 5d8bf2b)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja

@brandtbucher brandtbucher

Assignees

@JelleZijlstra JelleZijlstra

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JelleZijlstra @miss-islington @bedevere-bot @hauntsaninja @brandtbucher