Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-93358: Fix python-config docs for how to embed Python #98649

Merged
merged 1 commit into from Oct 29, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Oct 25, 2022

@corona10
Copy link
Member

corona10 commented Oct 26, 2022

@erlend-aasland I will take a look at this PR by this weekend :)

Copy link
Member

@corona10 corona10 left a comment

lgtm Thanks!

@erlend-aasland erlend-aasland merged commit e063c23 into python:main Oct 29, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 29, 2022

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒🤖

@erlend-aasland erlend-aasland deleted the embed branch Oct 29, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 29, 2022
…nGH-98649)

(cherry picked from commit e063c23)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 29, 2022

GH-98857 is a backport of this pull request to the 3.11 branch.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Oct 29, 2022

Thanks for the review, Dong-hee!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 29, 2022
…nGH-98649)

(cherry picked from commit e063c23)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 29, 2022

GH-98858 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Oct 29, 2022
(cherry picked from commit e063c23)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
miss-islington added a commit that referenced this pull request Oct 29, 2022
(cherry picked from commit e063c23)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants