gh-98608: Change _Py_NewInterpreter() to _Py_NewInterpreterFromConfig() #98609
+294
−40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
(Note that this PR adds "private" symbols. We'll probably make them public, and add docs, in a separate change.)
We do the following:
_PyInterpreterConfig
struct_Py_NewInterpreterFromConfig()
, inspired byPy_InitializeFromConfig()
(takes a_PyInterpreterConfig
instead ofisolated_subinterpreter
)isolated_subinterpreter
into the corresponding multiple granular settingsPyInterpreterState.feature_flags
to store those settingsPyInterpreterState *
PyConfig._isolated_interpreter
The current default (
Py_NewInterpeter()
andPy_Initialize*()
) allows fork, subprocess, and threads and the optional "isolated" interpreter disables all three. None of that changes here.Note that the given
_PyInterpreterConfig
will not be used (nor preserved, for now) outside_Py_NewInterpreterFromConfig()
. This contrasts with howPyConfig
is currently preserved, used, and modified outsidePy_InitializeFromConfig()
. I'd rather just avoid that mess from the start for_PyInterpreterConfig
.This change allows us to follow up with a number of improvements (e.g. stop disallowing subprocess and support disallowing exec instead).