gh-91058: Add error suggestions to 'import from' import errors #98305
Conversation
pablogsal
commented
Oct 15, 2022
•
- Issue: Typo hint message for from-imports? #91058
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
pablogsal
added
the
|
If you want to schedule another build, you need to add the " |
bedevere-bot
removed
the
pablogsal
added
the
|
If you want to schedule another build, you need to add the " |
bedevere-bot
removed
the
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Python/suggestions.c
Outdated
| return NULL; | ||
| } | ||
|
|
||
| PyObject* mod = PyImport_Import(mod_name); |
There was a problem hiding this comment.
I was wondering whether we could avoid "realy-importing" a module if it isn't already (e.g. whether it is currently cached or not)? (IIRC from x import y should put the x to the sys.modules, but might be missing something too).
There was a problem hiding this comment.
PyImport_Import goes through the cache if for whatever reason the module is already imported, no? (And indeed, the module is imported as part of raising the exception).
There was a problem hiding this comment.
PyImport_Import goes through the cache if for whatever reason the module is already imported, no? (And indeed, the module is imported as part of raising the exception).
Exactly, but consider the scenario where it isn't already imported and the module itself has some side effects (like it prints something at the top level). Importing it would then might produce unexpected side effects that only appear when the traceback is printed, so I thought whether we could limit this hint when the module is already cached.
if module not in sys.modules: return None # give up if it isn't already in the cache
module = PyImport_Import(mod_name)
...
There was a problem hiding this comment.
but consider the scenario where it isn't already imported and the module itself has some side effects
Hummmm. But isn't this a pre-condition for this kind of import error? If from foo import x fails to import foo then there is no lookup failure and we will never arrive here. And to be able to look x in foo then foo needs to be in sys.modules. Maybe I am missing something ... :(
There was a problem hiding this comment.
I think it's at least theoretically possible for the module to be removed by now, because some Python code may run between the time the error is thrown and the time this code runs. For example, in pythonrun.c we call print_exception_message() before print_exception_suggestions(), and that does a bunch of allocations and DECREFs that could trigger GC.
You could call https://docs.python.org/3/c-api/import.html#c.PyImport_GetModule instead to return the module only if it's already imported.
pablogsal
added
the
|
If you want to schedule another build, you need to add the " |
bedevere-bot
removed
the
Python/suggestions.c
Outdated
| return NULL; | ||
| } | ||
|
|
||
| PyObject* mod = PyImport_Import(mod_name); |
There was a problem hiding this comment.
I think it's at least theoretically possible for the module to be removed by now, because some Python code may run between the time the error is thrown and the time this code runs. For example, in pythonrun.c we call print_exception_message() before print_exception_suggestions(), and that does a bunch of allocations and DECREFs that could trigger GC.
You could call https://docs.python.org/3/c-api/import.html#c.PyImport_GetModule instead to return the module only if it's already imported.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
