Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle] Fixes HTML syntax regression introduced by #44570 #45583

Merged

Conversation

xavismeh
Copy link
Contributor

@xavismeh xavismeh commented Feb 28, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

The PR #44570 introduced an invalid HTML syntax and this PR fixes this regression

@carsonbot
Copy link

@carsonbot carsonbot commented Feb 28, 2022

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

xabbuh
xabbuh approved these changes Feb 28, 2022
fabpot
fabpot approved these changes Feb 28, 2022
@fabpot
Copy link
Member

@fabpot fabpot commented Feb 28, 2022

Thank you @xavismeh.

@fabpot fabpot merged commit 0ed2a8f into symfony:4.4 Feb 28, 2022
8 of 10 checks passed
@xavismeh xavismeh deleted the bugfix/webprofiler-bundle-html branch Mar 1, 2022
@fabpot fabpot mentioned this pull request Mar 5, 2022
@fabpot fabpot mentioned this pull request Mar 5, 2022
@fabpot fabpot mentioned this pull request Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants