[Notifier] Fix encoding of messages with FreeMobileTransport #45185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
reviewed
Jan 26, 2022
src/Symfony/Component/Notifier/Bridge/FreeMobile/FreeMobileTransport.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
reviewed
Jan 26, 2022
| @@ -60,7 +60,7 @@ protected function doSend(MessageInterface $message): SentMessage | |||
| $endpoint = sprintf('https://%s', $this->getEndpoint()); | |||
|
|
|||
| $response = $this->client->request('POST', $endpoint, [ | |||
| 'json' => [ | |||
| 'query' => [ | |||
There was a problem hiding this comment.
can you please try using body here instead?
if we keep query, can we keep POST or do we need GET as a method?
There was a problem hiding this comment.
commented on other discu #45185 (comment)
with query and POST it works well
carsonbot
changed the title
nicolas-grekas
changed the title
nicolas-grekas
requested review from
chalasr,
dunglas,
jderusse,
lyrixx,
wouterj,
xabbuh and
yceruto
as code owners
|
Thank you @94noni. |
This was referenced Jan 28, 2022
Merged
Merged
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When I first introduce this transport I used to test it with basic text, now with some French accent I need this fix otherwise the accent chars are not sent