Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm find-dupes pretty print diff #2912

Open
wants to merge 2 commits into
base: latest
Choose a base branch
from
Open

npm find-dupes pretty print diff #2912

wants to merge 2 commits into from
+34 −3

Conversation

chowkapow
Copy link
Contributor

@chowkapow chowkapow commented Mar 20, 2021

npm find-dupes for v7 currently does not have a descriptive message of what packages are being added/changed/removed.
This PR will output how each package would change.

image

References

Related to #2687

TODO

  • Add test cases
  • When package version remains the same, printing change mkdirp 1.0.4 -> 1.0.4 is not useful. Need to find the actual change.

image

  • Determine how to find node module path changes like below. I'm unable to find where this info lies in the diff object.
$ npx npm@6 find-dupes
move	source-map	0.5.7	node_modules/@babel/core/node_modules/source-map		node_modules/tap/node_modules/@babel/core/node_modules/source-map
move	@babel/helper-annotate-as-pure	7.10.4	node_modules/@babel/helper-annotate-as-pure		node_modules/tap/node_modules/@babel/helper-annotate-as-pure
move	@babel/helper-builder-react-jsx	7.10.4	node_modules/@babel/helper-builder-react-jsx		node_modules/tap/node_modules/@babel/helper-builder-react-jsx
move	@babel/helper-member-expression-to-functions	7.10.5	node_modules/@babel/helper-member-expression-to-functions		node_modules/tap/node_modules/@babel/helper-member-expression-to-functions
... etc

@chowkapow chowkapow requested a review from as a code owner Mar 20, 2021
@ruyadorno ruyadorno added the Agenda label Mar 20, 2021
@darcyclarke darcyclarke added the Release 7.x label Mar 23, 2021
@darcyclarke darcyclarke mentioned this pull request Mar 24, 2021
Closed
3 tasks
@darcyclarke darcyclarke added the semver:minor label Mar 24, 2021
@ruyadorno ruyadorno force-pushed the release-next branch 6 times, most recently from aee11af to 4b10024 Compare Mar 29, 2021
RonSherfey
RonSherfey suggested changes Apr 3, 2021
View changes
Copy link

@RonSherfey RonSherfey left a comment

requested changes .1

RonSherfey
RonSherfey suggested changes Apr 3, 2021
View changes
Copy link

@RonSherfey RonSherfey left a comment

changes 2

@darcyclarke darcyclarke mentioned this pull request Apr 7, 2021
Closed
@darcyclarke darcyclarke removed the Agenda label Apr 7, 2021
@darcyclarke darcyclarke self-assigned this Apr 9, 2021
@chowkapow
Copy link
Author

@chowkapow chowkapow commented Apr 23, 2021 •
edited

Hey @RonSherfey, what comments did you have for this? I can't find them for some reason.

How can I achieve the styling as suggested in the RFC meeting?
needs some work on the styling (should be consistent with outdated output with standardized colums/tablet layout)

RonSherfey
RonSherfey approved these changes Apr 24, 2021
View changes
Copy link

@RonSherfey RonSherfey left a comment

changes 2.0

@ruyadorno ruyadorno force-pushed the release-next branch 2 times, most recently from 6616513 to e5799e1 Compare May 31, 2021
@darcyclarke darcyclarke added this to the OSS - Sprint 35 milestone Aug 9, 2021
@darcyclarke darcyclarke removed this from the OSS - Sprint 35 milestone Aug 23, 2021
@darcyclarke darcyclarke added this to the OSS - Sprint 36 milestone Aug 23, 2021
@wraithgar wraithgar added Release 8.x and removed Release 7.x labels Oct 7, 2021
@wraithgar wraithgar changed the base branch from release-next to latest Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonSherfey RonSherfey

@npm/cli-team cli-team

Assignees

@darcyclarke darcyclarke

Labels
Release 8.x semver:minor
Projects
None yet
Milestone
OSS - Sprint 36
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@chowkapow @RonSherfey @wraithgar @ruyadorno @darcyclarke @lukekarrys