Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Devcontainer Support and Fixing Testcases for LinkListSort #3156

Merged
merged 8 commits into from Jun 24, 2022

Conversation

arindam89
Copy link
Contributor

@arindam89 arindam89 commented Jun 21, 2022

Add Devcontainer Support and Fixing Testcases for LinkListSort

  • Added Remote container Devleopment support now, this can be opened with remote dev containers directly without any setup.
  • Fix filename Link_List_test and fixed two testcases within it.
  • Changed the filename so that it gets run with mvn test

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.

@arindam89 arindam89 requested review from siriak and yanglbme as code owners Jun 21, 2022
@arindam89
Copy link
Contributor Author

arindam89 commented Jun 21, 2022

I am not getting what's the issue here for the build. I haven't touched

@arindam89
Copy link
Contributor Author

arindam89 commented Jun 21, 2022

Fixed a small bug on .github workflow as well.

siriak
siriak approved these changes Jun 24, 2022
Copy link
Member

@siriak siriak left a comment

Looks good, thanks!

@siriak siriak merged commit 0d97d0b into TheAlgorithms:master Jun 24, 2022
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants