[WebProfilerBundle] Improve css for explained doctrine queries in profiler #48036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I think @Amunak has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
|
If I'm correct, this is used by DoctrineBundle. In which case, I think we remove this from here and move it to DoctrineBundle instead. cc @javiereguiluz |
|
@PhilETaylor could you please have a look at DoctrineBundle, see if we shouldn't move some rules there? |
|
Yes. Please note that there's a pending Doctrine PR to update the profiler to 6.2 (doctrine/DoctrineBundle#1558). I'm trying to find time to finish it. |
|
Sorry for the delay, I can circle back to this PR (and a few other open ones I have) at the this weekend. |
|
Closing as this must be part of DoctrineBundle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the Doctrine Queries ->Explain query panel in Profiler looked and acted odd (Double top border, and doesn't resize to full width)
Improvements on #46750 from @zolikonta back in July.
Before
BEFORE.mov
After
AFTER.mov