Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail the CI if an optional module fails to compile #27466

Merged
merged 1 commit into from Jul 30, 2021
Merged

Fail the CI if an optional module fails to compile #27466

merged 1 commit into from Jul 30, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 29, 2021 •
edited

No description provided.

@pablogsal pablogsal requested a review from ambv Jul 29, 2021
@pablogsal pablogsal changed the title setup Fail the CI if an optional module fails to compile Jul 29, 2021
ambv
ambv approved these changes Jul 30, 2021
View changes
Copy link
Contributor

@ambv ambv left a comment

Calling the env variable PYTHONSTRICTEXTENSIONBUILD would be more consistent with the rest of our env variables.

@ambv ambv merged commit 7cad0be into python:main Jul 30, 2021
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 30, 2021

Thanks @pablogsal for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 30, 2021

Sorry, @pablogsal and @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7cad0bee80a536c7e47f54cf43174175834f30a0 3.10

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 30, 2021

Sorry @pablogsal and @ambv, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 7cad0bee80a536c7e47f54cf43174175834f30a0 3.9

@ambv
Copy link
Contributor

@ambv ambv commented Jul 30, 2021

We love you, @miss-islington, you absolute piece of trash!

pablogsal added a commit to pablogsal/cpython that referenced this issue Jul 30, 2021
@pablogsal
[3.10] Fail the CI if an optional module fails to compile (pythonGH-2…
7114317 
…7466).

(cherry picked from commit 7cad0be)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 30, 2021

GH-27482 is a backport of this pull request to the 3.9 branch.

pablogsal added a commit to pablogsal/cpython that referenced this issue Jul 30, 2021
@pablogsal
[3.9] Fail the CI if an optional module fails to compile (pythonGH-27466
6cce79d 
).

(cherry picked from commit 7cad0be)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this issue Jul 30, 2021
@pablogsal
[3.9] Fail the CI if an optional module fails to compile (GH-27466). (G…
3a806b1 
…H-27482)

(cherry picked from commit 7cad0be)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit to pablogsal/cpython that referenced this issue Jul 30, 2021
@pablogsal
[3.10] Fail the CI if an optional module fails to compile (pythonGH-2…
38ec767 
…7466).

(cherry picked from commit 7cad0be)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this issue Jul 30, 2021
@pablogsal
[3.10] Fail the CI if an optional module fails to compile (GH-27466). (…
c2e0b13 
…GH-27481)

(cherry picked from commit 7cad0be)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
JuniorJPDJ pushed a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
@pablogsal @JuniorJPDJ
Fail the CI if an optional module fails to compile (pythonGH-27466)
764a3e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambv ambv

Assignees

@ambv ambv

Labels
CLA signed skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pablogsal @miss-islington @ambv @bedevere-bot @the-knights-who-say-ni