Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mime] sync message serializer code for forward-compatibility #47753

Merged
merged 1 commit into from Oct 2, 2022
Merged

[Mime] sync message serializer code for forward-compatibility #47753

merged 1 commit into from Oct 2, 2022

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Oct 1, 2022 •
edited by fabpot

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 6.1 milestone Oct 1, 2022
@xabbuh xabbuh requested a review from dunglas as a code owner Oct 1, 2022
@xabbuh
Copy link
Member Author

xabbuh commented Oct 1, 2022

Before continuing here we should IMO discuss whether or not the BC promise applies to the serialized message format or if #47462 would introduce a BC break.

ping @fabpot

@fabpot
Copy link
Member

fabpot commented Oct 1, 2022

As the removed information was never used anyway, I think it's safe.

fabpot
fabpot approved these changes Oct 1, 2022
View changes
@xabbuh
Copy link
Member Author

xabbuh commented Oct 1, 2022

@fabpot I think I need to look into this a bit more. The deps=low job shouldn’t fail. I’ll take care of this later today.

@xabbuh xabbuh mentioned this pull request Oct 1, 2022
Closed
@xabbuh xabbuh force-pushed the pr-47462-6.1 branch 2 times, most recently from 9885be3 to 31f2680 Compare Oct 1, 2022
@xabbuh xabbuh force-pushed the pr-47462-6.1 branch 2 times, most recently from 906e4ee to 8f1683a Compare Oct 1, 2022
@xabbuh xabbuh changed the base branch from 6.1 to 5.4 Oct 1, 2022
@xabbuh xabbuh modified the milestones: 6.1, 5.4 Oct 1, 2022
fabpot
fabpot approved these changes Oct 2, 2022
View changes
@fabpot
Copy link
Member

fabpot commented Oct 2, 2022

Thank you @xabbuh.

@fabpot fabpot merged commit ac0b415 into symfony:5.4 Oct 2, 2022
9 of 11 checks passed
@xabbuh xabbuh deleted the pr-47462-6.1 branch Oct 2, 2022
This was referenced Oct 12, 2022
Merged
Merged
Merged
Reviewers

@nicolas-grekas nicolas-grekas

@fabpot fabpot

@dunglas dunglas

Assignees
No one assigned
Labels
Mime Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xabbuh @fabpot @nicolas-grekas @carsonbot