[TwigBridge] Using bootstrap 5 offset classes to indent input fields to prevent rendering empty label blocks #48070
Conversation
using bootstrap 5 offset classes to indent input fields to prevent rendering empty label blocks
adding offset class only when no label exists
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Thank you for your contribution. Please find a PR title that tells me what the PR does. The title will be used as a change log entry. |
davidhoelzel
changed the title
carsonbot
changed the title
There was a problem hiding this comment.
LGTM. I am not sure if replacing the empty divs is a BC break. Assuming this was just unintentional behavior as suggested in #46508 (comment) I would say it's fine
Failing Pipeline looks unrelated to me.
|
I am afraid that this change would break use cases where someone overrode the now changed blocks as they would now have to update their custom form themes to not have forms being rendered incorrectly. |
|
closing as explained, thanks David for giving it a try anyway |
using bootstrap 5 offset classes to indent input fields to prevent rendering empty label blocks
Instead of rendering empty div blocks when no label exists, the bootstrap offset classes are used to indent form-fields when using bootstrap 5 table layout with col-* classes.