Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-dom): ensure customElement handles empty props correctly. (fix #6361) #6182

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(runtime-dom): ensure customElement handles empty props correctly. (fix #6361) #6182

wants to merge 1 commit into from
+15 −1

Conversation

LinusBorg
Copy link
Member

@LinusBorg LinusBorg commented Jun 25, 2022

If a component wrapped with defineCustomElement() did not hae any props defined, and was passed any custom attribute (such as, in #6361, a data-v attribute), it would throw an error.

closes #6163

@LinusBorg
fix(runtime-dom): ensure customElement handles empty props correctly.
e527c8c 
fix Scoped attribute in Vue file affects the use of web component #6163
@LinusBorg LinusBorg added 🔨 p3-minor-bug feat: custom elements labels Jun 25, 2022
@LinusBorg LinusBorg moved this from PRs to Ready to Merge in Custom Elements Bugsquash Jun 25, 2022
@LinusBorg LinusBorg moved this from Ready to Merge to PRs in Custom Elements Bugsquash Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edison1105 edison1105

Assignees
No one assigned
Labels
feat: custom elements 🔨 p3-minor-bug
Projects
Custom Elements Bugsquash
PRs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web Component without props definitions breaks when passed custom attribute like data-v-xxxxxxx
2 participants
@LinusBorg @edison1105