Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python configure step checks for unused readelf #98948

Closed
serge-sans-paille opened this issue Nov 1, 2022 · 1 comment
Closed

Python configure step checks for unused readelf #98948

serge-sans-paille opened this issue Nov 1, 2022 · 1 comment
Labels
type-bug An unexpected behavior, bug, or error

Comments

@serge-sans-paille
Copy link
Contributor

serge-sans-paille commented Nov 1, 2022 •
edited by bedevere-bot

Bug report

During configure step, the presence of readelf on the host architecture is checked for, with an hard stop in case of cross compilation. The result of that check is never used. It got introduced in 5884449 for a check that no longer exists, so it can be removed.

Your environment

Linux 64 bit, Fedora 36, using main branch of cpython
@serge-sans-paille serge-sans-paille added the type-bug An unexpected behavior, bug, or error label Nov 1, 2022
serge-sans-paille added a commit to serge-sans-paille/cpython that referenced this issue Nov 1, 2022
@serge-sans-paille
pythongh-98948: Remove obsolete readelf dependency
26b6505 
This got introduced in commit 5884449
to determine if readline is already linked against curses or tinfo in
the setup.py, which is no longer present.
@bedevere-bot bedevere-bot mentioned this issue Nov 1, 2022
Merged
serge-sans-paille added a commit to serge-sans-paille/cpython that referenced this issue Nov 1, 2022
@serge-sans-paille
pythongh-98948: Remove obsolete readelf dependency
033f5f0 
This got introduced in commit 5884449
to determine if readline is already linked against curses or tinfo in
the setup.py, which is no longer present.
serge-sans-paille added a commit to serge-sans-paille/cpython that referenced this issue Nov 2, 2022
@serge-sans-paille
pythongh-98948: Remove obsolete readelf dependency
e425077 
This got introduced in commit 5884449
to determine if readline is already linked against curses or tinfo in
the setup.py, which is no longer present.
serge-sans-paille added a commit to serge-sans-paille/cpython that referenced this issue Nov 2, 2022
@serge-sans-paille
pythongh-98948: Remove obsolete readelf dependency
0fae64f 
This got introduced in commit 5884449
to determine if readline is already linked against curses or tinfo in
the setup.py, which is no longer present.
serge-sans-paille added a commit to serge-sans-paille/cpython that referenced this issue Nov 3, 2022
@serge-sans-paille
pythongh-98948: Remove obsolete readelf dependency
d69d8ad 
This got introduced in commit 5884449
to determine if readline is already linked against curses or tinfo in
the setup.py, which is no longer present.
serge-sans-paille added a commit to serge-sans-paille/cpython that referenced this issue Nov 3, 2022
@serge-sans-paille
pythongh-98948: Remove obsolete readelf dependency
0de323b 
This got introduced in commit 5884449
to determine if readline is already linked against curses or tinfo in
the setup.py, which is no longer present.
vstinner pushed a commit that referenced this issue Nov 3, 2022
@serge-sans-paille
gh-98948: Remove obsolete readelf dependency (#98949)
8c4de57 
This got introduced in commit 5884449
to determine if readline is already linked against curses or tinfo in
the setup.py, which is no longer present.
@vstinner
Copy link
Member

vstinner commented Nov 3, 2022

Fixed by 8c4de57

@vstinner vstinner closed this as completed Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vstinner @serge-sans-paille