gh-98948: Remove obsolete readelf dependency #98949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @vstinner , because I know he's in love with autoconf. I didn't run a local autoreconf because my local version is different from the one used to generate previous version. Instead, I manually edited the |
serge-sans-paille
force-pushed
the
remove/readelf-dependency
branch
from
26b6505
to
033f5f0
Compare
|
Can you try to add a NEWS entry in the Build category to document your change? See https://devguide.python.org/ about blurb. |
|
I added a commit to your branch: I ran "make regen-configure" which uses a container to get always the same version. |
serge-sans-paille
force-pushed
the
remove/readelf-dependency
branch
2 times, most recently
from
e425077
to
0fae64f
Compare
|
@vstinner : entry added & commits squashed. Thanks for the review! |
serge-sans-paille
force-pushed
the
remove/readelf-dependency
branch
from
0fae64f
to
d69d8ad
Compare
This got introduced in commit 5884449 to determine if readline is already linked against curses or tinfo in the setup.py, which is no longer present.
serge-sans-paille
force-pushed
the
remove/readelf-dependency
branch
from
d69d8ad
to
0de323b
Compare
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This got introduced in commit 5884449 to determine if readline is already linked against curses or tinfo in the setup.py, which is no longer present.