gh-92858: Improve error message for some suites with syntax error before ':' #92894

wookie184 · 2022-05-17T19:56:20Z

I left suites like try: as they shouldn't have anything before the colon anyway. There wouldn't be something before the colon that could be fixed, so I think the current error is fine.

Here's some before (first) after (second) examples with the test cases in the PR:

    class C(x for x in L):
           ^
SyntaxError: expected ':'

    class C(x for x in L):
              ^^^
SyntaxError: invalid syntax

    class R&D:
           ^
SyntaxError: expected ':'

    class R&D:
           ^
SyntaxError: invalid syntax

    for x in range 10:
                   ^^
SyntaxError: expected ':'

    for x in range 10:
                   ^^
SyntaxError: invalid syntax

    with block ad something:
               ^^
SyntaxError: expected ':'

    with block ad something:
               ^^
SyntaxError: invalid syntax

    match x x:
             ^
SyntaxError: expected ':'

    match x x:
            ^
SyntaxError: invalid syntax

wookie184 requested review from pablogsal and lysnikolaou as code owners May 17, 2022

bedevere-bot added the awaiting review label May 17, 2022

wookie184 added 2 commits May 17, 2022

Improve error message for some suites with syntax error before ':'

f1192cc

Add news

c2e406f

wookie184 force-pushed the improve-error-message branch from 68d17de to c2e406f Compare May 17, 2022

wookie184 mentioned this pull request May 26, 2022

SyntaxError location for *args in class bases is inconsistent #93165

Closed

gh-92858: Improve error message for some suites with syntax error before ':' #92894

Are you sure you want to change the base?

gh-92858: Improve error message for some suites with syntax error before ':' #92894

Conversation

wookie184 commented May 17, 2022 • edited

wookie184 commented May 17, 2022 •

edited