Skip to content

[MonologBridge] #48023 - Suggestion to deprecation issue construction of Monolog Logger #48054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

[MonologBridge] #48023 - Suggestion to deprecation issue construction of Monolog Logger #48054

wants to merge 10 commits into from

Conversation

rafael-neris
Copy link

@rafael-neris rafael-neris commented Oct 31, 2022 •
edited by xabbuh
Loading

Q A
Branch? 6.2 for features
Bug fix? yes
New feature? no
Deprecations? yes
Tickets Fix #47096 #48023
License MIT

@carsonbot carsonbot added this to the 6.2 milestone Oct 31, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

derrabus
derrabus requested changes Oct 31, 2022
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. However, you're proposing a change that will break existing Symfony applications. We need to find a better way to address the problem that you attempted to solve.

src/Symfony/Bridge/Monolog/Logger.php
@@ -20,7 +19,7 @@
/**
* @author Fabien Potencier <fabien@symfony.com>
*/
class Logger extends BaseLogger implements DebugLoggerInterface, ResetInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change because the Logger class won't pass a check like instanceof Monolog\Logger anymore.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @derrabus, thank you for review. Do you have any suggestion?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, I've commented my suggestion on both tickets. You cannot fix this class.

@fabpot fabpot modified the milestones: 6.2, 6.3 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus requested changes

Assignees
No one assigned
Labels
Bug Deprecation MonologBridge Status: Needs Work
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

MonologBridge shows deprecation error with Monolog 3.2
4 participants
@rafael-neris @carsonbot @derrabus @fabpot