[HttpFoundation] Check IPv6 is valid before comparing it #48050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Oct 31, 2022
fabpot
approved these changes
Nov 1, 2022
fabpot
requested review from
lyrixx,
yceruto,
wouterj,
dunglas and
xabbuh
as code owners
|
Thank you @PhilETaylor. |
Merged
This was referenced Nov 28, 2022
Merged
Merged
Merged
Merged
mremi
reviewed
Dec 8, 2022
fabpot
added a commit
that referenced
this pull request
Dec 9, 2022
…jected (bonroyage) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [HttpFoundation] IPv4-mapped IPv6 addresses incorrectly rejected | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #48420 <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT I've based it on 4.4 because that's where #48050 was merged into, but I guess I'm 1 day too late with a fix for that version Commits ------- 2170d3c [HttpFoundation] IPv4-mapped IPv6 addresses incorrectly rejected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Ensure that the
checkIp6only validates IPv6 addresses and ipv6 subnets.PR Assumes that IPv6 and ipv6 subnets can never have a period in them (which as far as I know, is correct).