[Cache] Fix proxy no expiration to the Redis #44577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbelyshkin
force-pushed
the
fix-proxy-no-expiration
branch
3 times, most recently
from
cd6cb2b
to
65bf172
Compare
|
Looks like UnitTest fails because Redis cannot connect to |
|
Hey! I think @ajcerezo has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
nicolas-grekas
reviewed
Dec 13, 2021
src/Symfony/Component/Cache/Adapter/AbstractTagAwareAdapter.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Cache/Tests/Adapter/TagAwareAndProxyAdapterIntegrationTest.php
Outdated
Show resolved
Hide resolved
sbelyshkin
force-pushed
the
fix-proxy-no-expiration
branch
2 times, most recently
from
484407c
to
8f8af9c
Compare
nicolas-grekas
force-pushed
the
fix-proxy-no-expiration
branch
from
8f8af9c
to
0812726
Compare
|
Thank you @sbelyshkin. |
This was referenced Dec 29, 2021
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
After #38156 RedisAdapter is not able to persist items with no expiration which come through ProxyAdapter because Redis does not persist keys with very large TTL such as \PHP_INT_MAX (64 bits).