[HttpClient] fix checking for recent curl consts #44743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Dec 21, 2021
| Q | A |
|---|---|
| Branch? | 5.3 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #42061 |
| License | MIT |
| Doc PR | - |
stof
approved these changes
Dec 21, 2021
derrabus
approved these changes
Dec 21, 2021
|
@derrabus quoted from https://www.php.net/manual/en/curl.requirements.php:
|
|
based on https://github.com/php/php-src/blob/0b5d371a9c2652c9775d807d29658b59a71848e5/ext/curl/sync-constants.php#L15, that doc seems outdated though. the min version seems to be 7.15.5 now. But that's still very old. Edit: fixed the doc in php/doc-en#1221 |
|
Yeah, I know. But still. |
This was referenced Dec 29, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.