Skip to content

[Form] Add option grouping in TimezoneType #40762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

arvodia
Copy link

@arvodia arvodia commented Apr 10, 2021

Add the grouping parameter in the options, which allows grouping according to the continents.

Q A
Branch? 5.x for features
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -
  • fix the tests as they have not been updated yet
  • submit changes to the documentation

Add the grouping parameter in the options, which allows grouping according to the continents.
@arvodia arvodia requested review from xabbuh and yceruto as code owners April 10, 2021 16:49
@carsonbot carsonbot changed the title [FORM] Add option grouping in TimezoneType [Form] Add option grouping in TimezoneType Apr 10, 2021
@jderusse jderusse added this to the 5.x milestone Apr 10, 2021
@arvodia
Copy link
Author

arvodia commented Apr 12, 2021

on the contrary with the grouping, except for a single loop on TimezoneType to have the grouping, whereas with the second method groupBy, it will take two loops to obtain the result, one which will build the array, and the other for group , look at the code I add two conditions in the existing loop .

@OskarStark OskarStark changed the title [Form] Add option grouping in TimezoneType [Form] Add option grouping in TimezoneType Aug 1, 2021
@fabpot fabpot modified the milestones: 5.4, 6.1 Nov 16, 2021
@fabpot fabpot modified the milestones: 6.1, 6.2 May 20, 2022
@nicolas-grekas nicolas-grekas modified the milestones: 6.2, 6.3 Nov 5, 2022
@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 6.4 May 23, 2023
@javiereguiluz
Copy link
Member

I like this proposal because it will probably make this long list more manageable for users. Thanks!

@derrabus
Copy link
Member

So do I, but it doesn't contain any tests.

@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 7.1 Nov 15, 2023
@javiereguiluz
Copy link
Member

@arvodia would you have some time to finish this contribution by adding some test?

You can take inspiration from the existing tests in https://github.com/symfony/symfony/blob/7.1/src/Symfony/Component/Form/Tests/Extension/Core/Type/TimezoneTypeTest.php

Thanks

@xabbuh xabbuh modified the milestones: 7.1, 7.2 May 15, 2024
@fabpot fabpot modified the milestones: 7.2, 7.3 Nov 20, 2024
@fabpot
Copy link
Member

fabpot commented Mar 29, 2025

Closing as there is no more activity on this PR and this cannot be merged without proper tests.

@fabpot fabpot closed this Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants