Skip to content

[Mailer] Added scheduling to API transport #46606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mkrysztofiak
Copy link

Added scheduling to API transport, according to Sendinblue documentation: https://developers.sendinblue.com/reference/sendtransacemail

@carsonbot carsonbot added this to the 6.2 milestone Jun 6, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@derrabus derrabus added the Mailer label Jun 6, 2022
@carsonbot carsonbot changed the title Added scheduling to API transport [Mailer] Added scheduling to API transport Jun 6, 2022
@fabpot
Copy link
Member

fabpot commented Jul 25, 2022

We tend to not add features that are only available on one provider only. Could you have a look at some other providers to see if they also support this? If yes, we would be able to abstract it and let other providers implement it.

@nicolas-grekas nicolas-grekas modified the milestones: 6.2, 6.3 Nov 5, 2022
@nicolas-grekas
Copy link
Member

Closing as this stalled and #47112 might be the more generic solution @fabpot is looking for.
Thanks for submitting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants