Skip to content

[Messenger] Add resettable option for InMemoryTransport #47492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexndlm
Copy link
Contributor

@alexndlm alexndlm commented Sep 5, 2022

Q A
Branch? 6.2
Bug fix? no
New feature? yes
Deprecations? no
License MIT
Doc PR symfony/symfony-docs#17254

@ERuban
Copy link
Contributor

ERuban commented Sep 5, 2022

I want it in 6.x branch too

@fabpot
Copy link
Member

fabpot commented Sep 6, 2022

That would be for 6.2, but I’d like to better understand the use case to see if there isn’t a better solution.

@alexndlm
Copy link
Contributor Author

alexndlm commented Sep 6, 2022

@fabpot In tests, I run worker and later want to check sent messages.

I use this trait - worker is runned with messenger.listener.reset_services subscriber. I need this to test all flow, as some of my code depends on service resetting.

@alexndlm alexndlm force-pushed the feature/messanger-add-ressetable-option-to-in-memory-transport branch from 578dbc3 to 9f44102 Compare September 7, 2022 06:30
@alexndlm alexndlm changed the base branch from 5.4 to 6.2 September 7, 2022 06:30
@alexndlm alexndlm requested review from a user and removed request for dunglas, lyrixx, jderusse, wouterj, OskarStark, xabbuh, yceruto and chalasr September 7, 2022 06:35
@xabbuh xabbuh modified the milestones: 5.4, 6.2 Sep 9, 2022
@nicolas-grekas nicolas-grekas modified the milestones: 6.2, 6.3 Nov 5, 2022
@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 6.4 May 23, 2023
@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 7.1 Nov 15, 2023
@xabbuh xabbuh modified the milestones: 7.1, 7.2 May 15, 2024
@fabpot fabpot modified the milestones: 7.2, 7.3 Nov 20, 2024
@nicolas-grekas
Copy link
Member

I don't understand what's missing with the existing testing infrastructure based the profiler.
Since the class is not final, you can achieve this on your side.
For Symfony, I'm not convinced this makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants