[Console] Support completion for bash functions #48179
Merged
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I think @remicollet has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
|
Hi @Chi-teck, can you provide an example of "bash function", so that we can test your change? |
|
@GromNaN It could be a simple wrapper around any Symfony app that already have completions dumped.
function some-app() {
/var/www/vendor/bin/some-app
}
Check if completions work for |
GromNaN
approved these changes
Nov 12, 2022
Thank you for the reproducer. I think the function should transmit the arguments so that the completion works.
function some-app() {
/var/www/vendor/bin/some-app "$@"
}
@symfony/mergers I think this is a bugfix that should be merged in 5.4.
fabpot
approved these changes
Nov 19, 2022
fabpot
requested review from
lyrixx,
yceruto,
dunglas,
OskarStark and
xabbuh
as code owners
|
Thank you @Chi-teck. |
This was referenced Nov 25, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I often use bash functions as wrappers for executable files that live in vendor/bin. So that they can be executed from any location within a project. Symfony Console has recently added support for Bash completions but right now that only applies to executable files and aliases. This PR adds support for Bash functions.