Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Py_INCREF()/Py_XINCREF() usage with Py_NewRef()/Py_XNewRef() #99300

Open
vstinner opened this issue Nov 9, 2022 · 0 comments
Open

Replace Py_INCREF()/Py_XINCREF() usage with Py_NewRef()/Py_XNewRef() #99300

vstinner opened this issue Nov 9, 2022 · 0 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@vstinner
Copy link
Member

vstinner commented Nov 9, 2022 •
edited by bedevere-bot

I added Py_NewRef() and Py_XNewRef() to Python 3.10 C API. IMO using them make to code easier to read and make the code looks "more correct". Examples:

(A) Assign + INCREF:

-                result = Py_False;
-                Py_INCREF(result);
+                result = Py_NewRef(Py_False);

(B) INCREF + assign:

-        Py_INCREF(last);
-        self->last = last;
+        self->last = Py_NewRef(last);

(C) INCREF + return:

-    Py_XINCREF(result);
-    return result;
+    return Py_XNewRef(result);

While technically, Py_INCREF() and Py_XINCREF() modify the object in-place (increment their reference counter), for me Py_NewRef() makes me sense: it creates "a new reference".

The example (A) is weird: it assigns a variable to something, and only later creates a new reference. For me, the syntax with Py_NewRef() makes more sense.

Examples (B) and (C) are shorter with Py_NewRef(), and again, IMO makes more sense and are more readable.
@vstinner vstinner added the type-bug An unexpected behavior, bug, or error label Nov 9, 2022
vstinner added a commit to vstinner/cpython that referenced this issue Nov 9, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Python/ directory
c1b7ccb 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Python/ directory.
vstinner added a commit to vstinner/cpython that referenced this issue Nov 9, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Python/ directory
984bc93 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Python/ directory.
vstinner added a commit to vstinner/cpython that referenced this issue Nov 9, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Python/ directory
60e49c1 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Python/ directory.
@bedevere-bot bedevere-bot mentioned this issue Nov 9, 2022
Merged
@vstinner vstinner mentioned this issue Nov 9, 2022
Merged
vstinner added a commit that referenced this issue Nov 10, 2022
@vstinner
gh-99300: Use Py_NewRef() in Python/ directory (#99302)
d8f239d 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Python/ directory.
vstinner added a commit to vstinner/cpython that referenced this issue Nov 10, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Python/ directory
cade9b6 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Python/ directory.
vstinner added a commit to vstinner/cpython that referenced this issue Nov 10, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Python/ directory
b313886 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Python/ directory.
vstinner added a commit to vstinner/cpython that referenced this issue Nov 10, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Python/ directory
3ca67a8 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Python/ directory.
@bedevere-bot bedevere-bot mentioned this issue Nov 10, 2022
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Nov 10, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Python/ directory
8c8290a 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Python/ directory.

Update Parser/asdl_c.py to regenerate Python/Python-ast.c.
vstinner added a commit to vstinner/cpython that referenced this issue Nov 10, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Python/ceval.c
c9fc0e9 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in Python/ceval.c and related files.
vstinner added a commit to vstinner/cpython that referenced this issue Nov 10, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Python/ceval.c
00fdf12 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in Python/ceval.c and related files.
@bedevere-bot bedevere-bot mentioned this issue Nov 10, 2022
Merged
vstinner added a commit that referenced this issue Nov 10, 2022
@vstinner
gh-99300: Use Py_NewRef() in Python/ directory (#99317)
231d83b 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Python/ directory.

Update Parser/asdl_c.py to regenerate Python/Python-ast.c.
vstinner added a commit that referenced this issue Nov 10, 2022
@vstinner
gh-99300: Use Py_NewRef() in Python/ceval.c (#99318)
2e343fc 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in Python/ceval.c and related files.
vstinner added a commit to vstinner/cpython that referenced this issue Nov 10, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Parser/ directory
4a51756 
Replace Py_INCREF() with Py_NewRef() in C files of the Parser/
directory and in the PEG generator.
@bedevere-bot bedevere-bot mentioned this issue Nov 10, 2022
Merged
vstinner added a commit that referenced this issue Nov 10, 2022
@vstinner
gh-99300: Use Py_NewRef() in Parser/ directory (#99330)
4ce2a20 
Replace Py_INCREF() with Py_NewRef() in C files of the Parser/
directory and in the PEG generator.
vstinner added a commit to vstinner/cpython that referenced this issue Nov 10, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Objects/ directory
763fe0a 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Objects/ directory.
vstinner added a commit to vstinner/cpython that referenced this issue Nov 10, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Objects/ directory
b740fdb 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Objects/ directory.
@bedevere-bot bedevere-bot mentioned this issue Nov 10, 2022
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Nov 10, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Objects/dictobject.c
ecff35c 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in Objects/dictobject.c.
vstinner added a commit to vstinner/cpython that referenced this issue Nov 10, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Objects/dictobject.c
7a2e39d 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in Objects/dictobject.c.
@bedevere-bot bedevere-bot mentioned this issue Nov 10, 2022
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Nov 10, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Objects/ directory
39505b9 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Objects/ directory.
vstinner added a commit to vstinner/cpython that referenced this issue Nov 10, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Objects/ directory
8a95ebf 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Objects/ directory.
@bedevere-bot bedevere-bot mentioned this issue Nov 10, 2022
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Nov 10, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Objects/listobject.c
4477ba5 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in Objects/listobject.c.
@bedevere-bot bedevere-bot mentioned this issue Nov 10, 2022
Merged
vstinner added a commit that referenced this issue Nov 10, 2022
@vstinner
gh-99300: Use Py_NewRef() in Objects/dictobject.c (#99333)
6dedf42 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in Objects/dictobject.c.
vstinner added a commit that referenced this issue Nov 10, 2022
@vstinner
gh-99300: Use Py_NewRef() in Objects/ directory (#99332)
c0feb99 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Objects/ directory.
gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue Nov 10, 2022
@vstinner @gvanrossum
pythongh-99300: Use Py_NewRef() in Objects/ directory (python#99332)
4ee85e7 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Objects/ directory.
gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue Nov 10, 2022
@vstinner @gvanrossum
pythongh-99300: Use Py_NewRef() in Objects/dictobject.c (python#99333)
873da31 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in Objects/dictobject.c.
vstinner added a commit that referenced this issue Nov 10, 2022
@vstinner
gh-99300: Use Py_NewRef() in Objects/listobject.c (#99336)
dbf8613 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in Objects/listobject.c.
vstinner added a commit that referenced this issue Nov 10, 2022
@vstinner
gh-99300: Use Py_NewRef() in Objects/ directory (#99335)
584e55b 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Objects/ directory.
vstinner added a commit to vstinner/cpython that referenced this issue Nov 10, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Objects/ directory
4fdd46e 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Objects/ directory.
vstinner added a commit to vstinner/cpython that referenced this issue Nov 10, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Objects/ directory
28ced09 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Objects/ directory.
@bedevere-bot bedevere-bot mentioned this issue Nov 10, 2022
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Nov 10, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Objects/ directory
f19a0b2 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Objects/ directory.
vstinner added a commit to vstinner/cpython that referenced this issue Nov 10, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Objects/ directory
cda034b 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Objects/ directory.
@bedevere-bot bedevere-bot mentioned this issue Nov 10, 2022
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Nov 10, 2022
@vstinner
pythongh-99300: Use Py_NewRef() in Objects/ directory
5d8a94b 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Objects/ directory.
vstinner added a commit that referenced this issue Nov 10, 2022
@vstinner
gh-99300: Use Py_NewRef() in Objects/ directory (#99351)
1960eb0 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Objects/ directory.
vstinner added a commit that referenced this issue Nov 10, 2022
@vstinner
gh-99300: Use Py_NewRef() in Objects/ directory (#99354)
3a1dde8 
Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in C files of the Objects/ directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vstinner