Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use better names for pos-only parameters in stdlib #8637

Merged
merged 3 commits into from Aug 28, 2022
Merged

Use better names for pos-only parameters in stdlib #8637

merged 3 commits into from Aug 28, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Aug 28, 2022

I understand that this argument is "pos-only" emulation.
But, still __k is better for readability, because __v is used for values, not keys.

@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood requested changes Aug 28, 2022
View changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

If we're going to do this, let's do it properly ;)

stdlib/builtins.pyi Outdated Show resolved Hide resolved
stdlib/typing.pyi Outdated Show resolved Hide resolved
@sobolevn
Copy link
Member Author

sobolevn commented Aug 28, 2022

Done!

  • __k -> __key
  • __v -> __value

@sobolevn sobolevn changed the title Use __k, not __v for __delitem__ Use better names for pos-only parameters in stdlib Aug 28, 2022
@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood approved these changes Aug 28, 2022
View changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 6e985ef into python:master Aug 28, 2022
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sobolevn @AlexWaygood