Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): allow readonly arrays in NgModule imports and exports #48106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(core): allow readonly arrays in NgModule imports and exports #48106

wants to merge 1 commit into from
+73 −4

Conversation

pkozlowski-opensource
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource commented Nov 17, 2022

NgModule should support readonly arrays in @NgModule.imports and @NgModule.exports.

Partly fixes #48089 (#48091 is also needed)

@pkozlowski-opensource
fix(core): allow readonly arrays in NgModule imports and exports
c985860 
NgModule should support readonly arrays in `@NgModule.imports` and
`@NgModule.exports`.

Fixes angular#48089
@pkozlowski-opensource pkozlowski-opensource added area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release cross-cutting: standalone Issues related to the NgModule-less world labels Nov 17, 2022
@ngbot ngbot bot modified the milestone: Backlog Nov 17, 2022
@pkozlowski-opensource
Copy link
Member Author

pkozlowski-opensource commented Nov 17, 2022

Note to a reviewer: I'm not sure if we can make this change in the patch release as technically it is widening the API surface. On the other hand it could be seen as a fix. On a fence here.

@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review Nov 17, 2022
@pkozlowski-opensource pkozlowski-opensource added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 17, 2022
@pullapprove pullapprove bot requested review from alxhub, dylhunn and jessicajaniuk Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxhub alxhub

@dylhunn dylhunn

@jessicajaniuk jessicajaniuk

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime cross-cutting: standalone Issues related to the NgModule-less world target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Exported array of standalone components cannot be imported
1 participant
@pkozlowski-opensource