Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black in travis ci #551

Merged
merged 5 commits into from Oct 16, 2019
Merged

Black in travis ci #551

merged 5 commits into from Oct 16, 2019

Conversation

@laurent-pck
Copy link
Contributor

@laurent-pck laurent-pck commented Oct 11, 2019

(Put an X inside the [ ] to denote check mark [X].)

  • If creating a new file :

    • added links to it in the README files ?
    • included tests with it ?
    • added description (overview of algorithm, time and space complexity, and possible edge case) in docstrings ?
  • if done some changes :

    • wrote short description in the PR explaining what the changes do ?
    • Fixes #479 if related to any issue
  • other

This fixes issue #479 if you would like to add black in the CI.

It will not make every build (from this PR) fail in the CI but log all files that would be reformatted. In order to install black during CI, it was necessary to drop python 3.5 as black needs python 3.6.0+

@keon keon merged commit 1aef871 into keon:master Oct 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.