Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] Uses PHP Native Type Declarations 🐘 #44545

Draft
wants to merge 59 commits into
base: master
Choose a base branch
from
Draft

[10.x] Uses PHP Native Type Declarations 🐘 #44545

wants to merge 59 commits into from
+181 ∄1�7459

Conversation

nunomaduro
Copy link
Member

@nunomaduro nunomaduro commented Oct 11, 2022

Please check laravel/laravel#6010 for details about this pull request.

@nunomaduro nunomaduro self-assigned this Oct 11, 2022
@nunomaduro nunomaduro changed the base branch from 9.x to master Oct 11, 2022
@nunomaduro nunomaduro mentioned this pull request Oct 11, 2022
Draft
42 tasks
@SuperDJ
Copy link
Contributor

SuperDJ commented Oct 12, 2022 •
edited

@nunomaduro I might have something for you: https://github.com/SuperDJ/framework/tree/master-contract-types and #44442

@SuperDJ SuperDJ mentioned this pull request Oct 12, 2022
Closed
@tontonsb tontonsb mentioned this pull request Oct 23, 2022
Closed
nunomaduro added 23 commits Oct 25, 2022
@nunomaduro
Adds types to up and down migration methods
f247218
@nunomaduro
Adds types casts get and set methods
dc62994
@nunomaduro
Adds types to HTTP Authenticate redirectTo method
8bd91d7
@nunomaduro
Adds types to handle middleware methods
fab864e
@nunomaduro
Adds types to join channel method
6402941
@nunomaduro
Adds types to handle command method
60f8ad6
@nunomaduro
Adds types to render component method
febadd1
@nunomaduro
Adds types to broadcastOn event method
1532f35
@nunomaduro
Improves types order
4983e29
@nunomaduro
Adds types to definition model factory method
7a26182
@nunomaduro
Adds types to handle job method
2893d0c
@nunomaduro
Types missing render method in Exception
b06feb1
@nunomaduro
Adds types to handle listener method
97270ff
@nunomaduro
Adds types to render and report Exception method
73cdf54
@nunomaduro
Adds types to build Mail method
6020f72
@nunomaduro
Fixes missing param type in handle middleware method
c29ffa5
@nunomaduro
Adds types to notifications
c5bf70c
@nunomaduro
Adds types to observers
1ffa04c
@nunomaduro
Adds types to policies
9fb3693
@nunomaduro
Adds types to providers
76654a6
@nunomaduro
Adds types to requests
7b72414
@nunomaduro
Adds types to resources
c8e795a
@nunomaduro
Adds types to rules
dceb7a5
driesvints
driesvints requested changes Oct 27, 2022
View changes
Copy link
Member

@driesvints driesvints left a comment

Highlighted a few places where docblocks still need to be updated but there seem to be many more in this PR yet. So best to go through those once more.

src/Illuminate/Contracts/Database/Eloquent/CastsAttributes.php Show resolved Hide resolved
src/Illuminate/Contracts/Validation/DataAwareRule.php Show resolved Hide resolved
src/Illuminate/Contracts/Validation/InvokableRule.php Show resolved Hide resolved
src/Illuminate/Contracts/Validation/ValidatorAwareRule.php Show resolved Hide resolved
@Haythamasalama
Copy link

Haythamasalama commented Oct 31, 2022

I love it ❤️❤️

@foremtehan
Copy link
Contributor

foremtehan commented Dec 18, 2022

#45314 (Does not have types)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RTippin RTippin

@browner12 browner12

@jrd-lewis jrd-lewis

@driesvints driesvints

Assignees

@nunomaduro nunomaduro

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@nunomaduro @SuperDJ @Haythamasalama @foremtehan @driesvints @RTippin @browner12 @jrd-lewis