[9.x] Added generic typing to EnumeratesValues::flatMap method. #44772
+14
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mad-briller
force-pushed
the
flat-map-generics
branch
2 times, most recently
from
a7745ab
to
43860cb
Compare
|
|
tyabu12
reviewed
Oct 28, 2022
mad-briller
changed the title
|
@nunomaduro can you take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Improves the generic typing of
EnumeratesValuesby providing them for theflatMap()method.Using
flatMapright now causes all type information to be lost, and explicitly states there will only be integer keys, whencollapse()can produce bothstringandintkeys thanks to it's use ofarray_merge().ref: nunomaduro/larastan#1427