[Notifier] Add iSendPro bridge #48253
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "6.2" but it seems your PR description refers to branch "6.3". Cheers! Carsonbot |
OskarStark
reviewed
Nov 20, 2022
src/Symfony/Component/Notifier/Bridge/Isendpro/IsendproTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Isendpro/IsendproTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Isendpro/phpunit.xml.dist
Outdated
Show resolved
Hide resolved
This was referenced Nov 20, 2022
|
Thanks @OskarStark for your review ! I've created the recipe (it's my first recipe, it's a try :)), documentation and fix your comments. |
OskarStark
reviewed
Nov 20, 2022
src/Symfony/Component/Notifier/Bridge/Isendpro/IsendproTransport.php
Outdated
Show resolved
Hide resolved
|
Please adjust the |
OskarStark
approved these changes
Nov 20, 2022
|
Can you please link the doc and recipe PR in the PR header? Thanks |
|
I search all places in Symfony where the notifiers are use and adjust it (I'm not sure it's the good way) PR header is updated. Thanks you very much for your review ! |
OskarStark
changed the title
|
Friendly ping @fabpot |
src/Symfony/Component/Notifier/Bridge/Isendpro/IsendproTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Isendpro/IsendproTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Isendpro/IsendproTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Isendpro/IsendproTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Isendpro/IsendproTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Isendpro/IsendproTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Isendpro/IsendproTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Isendpro/IsendproTransportFactory.php
Outdated
Show resolved
Hide resolved
|
Thanks for your review. |
leblanc-simon
requested review from
xabbuh,
wouterj,
chalasr and
yceruto
as code owners
fabpot
added a commit
that referenced
this pull request
Dec 2, 2022
This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [Notifier] Add iSendPro bridge | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#17450 |Recipe | symfony/recipes#1147 This PR add the notifier bridge for [Isendpro](https://www.isendpro.com/) (SMS). Replace the #48253 (I failed to target new branch with Git, sorry...) Commits ------- 695d5eb [Notifier] Add iSendPro bridge
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Dec 4, 2022
This PR was merged into the 6.3 branch. Discussion ---------- [Notifier] Add iSendPro notifier Add the iSendPro notifier in documentation. Related with the PR : symfony/symfony#48253 Commits ------- b2a2c87 [Notifier] Add iSendPro notifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the notifier bridge for Isendpro (SMS).