Minor (comment only), part 2 #48249
Merged
Minor (comment only), part 2 #48249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,7 +55,7 @@ public function getRoles(): array; | |||
| public function eraseCredentials(); | |||
|
|
|||
| /** | |||
| * Returns the identifier for this user (e.g. its username or email address). | |||
| * Returns the identifier for this user (e.g. username or email address). | |||
There was a problem hiding this comment.
If you want, I can surely add "their". But IMO it's clear anyway in this context about whose username we're talking...
fabpot
approved these changes
Dec 9, 2022
Second attempt of symfony#48242 Even if you didn't like "visual", you still can't say "its" to a user ;-)
fabpot
requested review from
lyrixx,
yceruto,
dunglas,
OskarStark,
jderusse and
xabbuh
as code owners
|
Thank you @ThomasLandauer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt of #48242
Even if you didn't like "visual", you still can't say "its" to a user ;-)