Skip to content

[DoctrineBridge][Form] Run tests with doctrine/collections 2 #48260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2022

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Nov 20, 2022

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

Blocked by doctrine/collections#353

@carsonbot carsonbot changed the title Run tests with doctrine/collections 2 [DoctrineBridge][Form] Run tests with doctrine/collections 2 Nov 20, 2022
@carsonbot carsonbot added this to the 4.4 milestone Nov 20, 2022
@derrabus derrabus closed this Nov 20, 2022
@derrabus derrabus reopened this Nov 20, 2022
@derrabus derrabus closed this Nov 21, 2022
@derrabus derrabus reopened this Nov 21, 2022
@nicolas-grekas
Copy link
Member

It'd be great fixing the "Remaining indirect deprecation" before merging.

@fabpot fabpot modified the milestones: 4.4, 5.4 Nov 23, 2022
@derrabus
Copy link
Member Author

I thought I had done that. I'll check again.

@derrabus derrabus changed the base branch from 4.4 to 5.4 November 23, 2022 12:49
@derrabus derrabus force-pushed the bugfix/collections-2 branch from 6fbce29 to 2f4fdaa Compare November 23, 2022 12:49
@derrabus derrabus force-pushed the bugfix/collections-2 branch from 2f4fdaa to 8a50303 Compare November 25, 2022 18:56
@derrabus
Copy link
Member Author

PR is ready. The remaining failures look unrelated to me.

@fabpot
Copy link
Member

fabpot commented Nov 26, 2022

Thank you @derrabus.

@fabpot fabpot merged commit 84e90f6 into symfony:5.4 Nov 26, 2022
@derrabus derrabus deleted the bugfix/collections-2 branch December 9, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants